search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

fluid shell interaction model. #184

Open DrChiZhang opened 1 year ago

DrChiZhang commented 1 year ago

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

BenceVirtonomy commented 1 year ago

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

DrChiZhang commented 1 year ago

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

Sure, I have already done some work. You can follow tests/user-exampels/test-2d-square-fsi in fluid-shell-interaction branch .

BenceVirtonomy commented 1 year ago

@ChiZhangatTUM We would like to make a 3d test here too. I was wondering if you already have the elastic beam in a flow case at least in 2d? I mean test_2d_fsi2 case with the shell? I'm asking you to avoid doing something you have done already. If you have it, I would try to expand it to 3d otherwise build it from scratch.

Sure, I have already done some work. You can follow tests/user-exampels/test-2d-square-fsi in fluid-shell-interaction branch .

Ahh, I see. Could you make a draft PR from that branch? That way we can all see the changes there too.

Xiangyu-Hu commented 1 year ago

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

Dear Chi, I think that we need a discussion on the pull request to clarify several issues.

DrChiZhang commented 1 year ago

1, add fluid shell interaction dynamics. 2, add new test case of sloshing flow with baffle 3, generalise complex dynamics according with adding third contact body to contact body list.

Dear Chi, I think that we need a discussion on the pull request to clarify several issues.

Sure, I will be office from Tuesday to Thursday.

DrChiZhang commented 1 year ago

Hi all, As we have lots of issues on this PR. I will close it without merging in the following days.

BenceVirtonomy commented 1 year ago

Hi all, As we have lots of issues on this PR. I will close it without merging in the following days.

You don't need to close it Chi, unless you want to start from scratch. You can set it back to draft so that we can still see the changes.

DrChiZhang commented 1 year ago

I will add it to the user_examples of this current branch in the next commit, and you can modify and add it to test with proper validation.

BenceVirtonomy commented 1 year ago

@ChiZhangatTUM is the fluid-shell-interaction your new branch? can you please make a PR from that and close this one? Thx!