search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

change the Eulerian classes out of the master and edit the cmakelist to make the Eulerian cases run in the ctest. #299

Closed ZhentongWang closed 11 months ago

ZhentongWang commented 11 months ago

change the regression files further to make the tests successful in CI/MacOS

ZhentongWang commented 11 months ago

also add Yongchuan as a collaborator to review the pull request

Xiangyu-Hu commented 11 months ago

What did you changed for McOS?

ZhentongWang commented 11 months ago

What did you changed for McOS?

At the beginning, fails in macOS show that case of flow around cylinder is unsuccessful because of regression files, so I change the regression file in the Eulerian flow around cylinder case, specifically I decrease the value in the "generateDatabase" class to generate new regression files and then use these to replace the original regression files and now Eulerian flow around cylinder case could run successfully.

DrChiZhang commented 11 months ago

What did you changed for McOS?

At the beginning, fails in macOS show that case of flow around cylinder is unsuccessful because of regression files, so I change the regression file in the Eulerian flow around cylinder case, specifically I decrease the value in the "generateDatabase" class to generate new regression files and then use these to replace the original regression files and now Eulerian flow around cylinder case could run successfully.

A little confusing. What do you mean by "new regression files"?

DrChiZhang commented 11 months ago

Looks like you have new reference data in regression test? According to you #2 pull request.

Xiangyu-Hu commented 11 months ago

I think Zhengtong means that he decreased threshold for all systems.

ZhentongWang commented 11 months ago

when we generate the regression files, we would use function .generateDataBase(5.0e-3) in class named RegressionTestDynamicTimeWarping. At the first, in the Eulerian flow around cylinder case, I set value as 5.0e-3 to generate the regression files but failed in CI/macOS, then I decrease the value from 5.0e-3 to 1.0e-3 to generate the regression files, and then results could pass in the CI/macOS.

Xiangyu-Hu commented 11 months ago

when we generate the regression files, we would use function .generateDataBase(5.0e-3) in class named RegressionTestDynamicTimeWarping. At the first, in the Eulerian flow around cylinder case, I set value as 5.0e-3 to generate the regression files but failed in CI/macOS, then I decrease the value from 5.0e-3 to 1.0e-3 to generate the regression files, and then results could pass in the CI/macOS.

This is OK.