search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Non-linear wave - tlp structure interaction #305

Closed ncsalis closed 10 months ago

ncsalis commented 11 months ago

3D case runs in 1800 s in CI. Maybe you can deactivate after passing

FabienPean-Virtonomy commented 11 months ago

Hi could could you please expand a bit each example name ? wfsi and nlwfsi are hard to read and interpret quickly. It would be even better if you could add a small readme in each describing the case and/or a picture

ncsalis commented 11 months ago

Hi could could you please expand a bit each example name ? wfsi and nlwfsi are hard to read and interpret quickly. It would be even better if you could add a small readme in each describing the case and/or a picture

The name wfsi stands for wave floating structure interaction and the nlwfsi stands for non-linear wave fluid structure interaction. I will add the readme and picture example in a future commit, thank you for your suggestion

FabienPean-Virtonomy commented 11 months ago

FSI is quite common but the whole acronym made it hard (felt like reading blas/lapack function name 😄), IMO wave_fsi and nonlinear_wave_fsi would be clearer

DrChiZhang commented 11 months ago

Any experimental data for the validation?

ncsalis commented 11 months ago

@FabienPean-Virtonomy Thank you for the suggestion, I will modify the names!

@ChiZhangatTUM Yes, there are experimental data to validate the model.

DrChiZhang commented 11 months ago

The windows CI has error and can not install dependency correctly, please cancel the actions. I am fixing the windows CI bug, after that you can merge from master.

ncsalis commented 11 months ago

@ChiZhangatTUM sorry, I thought that I already cancelled the checks

DrChiZhang commented 11 months ago

The CI bug was fixed and you can merge from master and then PR.

Xiangyu-Hu commented 10 months ago

@ncsalis you need pull the master again so that we can merge it to master.

ncsalis commented 10 months ago

Before merging with master I have to generate regression ( result changed after using the B correction). In this week I will do it