search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Nonlinear wave interaction case in 3d takes too long time in CI #357

Closed Xiangyu-Hu closed 10 months ago

Xiangyu-Hu commented 10 months ago

The nonlinear wave interaction case in 3d takes too long time. It takes about 2500 seconds in CI. @ncsalis Could it possible to shorten the time to about 1000 seconds?

Xiangyu-Hu commented 10 months ago

Probably, running for less physical time?

ncsalis commented 10 months ago

If we want to shorten the simulation time in CI, the modifications must include lower particle resolution, shorter channel and shorter physical time. I have done it, tomorrow I will check results and re-build regression since time sep changed.

If 1000 seconds in CI cannot be achieved with this new configuration I suggest to de-activate the case from running in CI.

ncsalis commented 10 months ago

With this configuration takes (circa) 1600s on linux, 2400s on windows and 1400s on macOS.

It's better to deactivate the case for CI or remove it. In the following weeks I shall prepare a different configuration for testing purposes.

Xiangyu-Hu commented 10 months ago

OK. You can replace the 3d case with a new one. Thanks.

ncsalis commented 10 months ago

Modified case. Now it should take from 250 to 300 seconds in CI.

nlwfsi_lq

Xiangyu-Hu commented 10 months ago

Good. I think that it is good enough.

Xiangyu-Hu commented 10 months ago

We can replace the old one with this.

ncsalis commented 10 months ago

Is already substituted and running in #358. Is not as fast as I hoped, in linux takes circa 600s. If you need faster I have to think another different configuration.