search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

add getRotationFromPseudoNormalForSmallDeformation. #399

Closed rukawaaaaaaa closed 8 months ago

rukawaaaaaaa commented 9 months ago

add a new getRotationFromPseudoNormalForSmallDeformation

Xiangyu-Hu commented 9 months ago

@rukawaaaaaaa I think that CI is not able to pass.

DongWuTUM commented 9 months ago

Thank you! Since the code should be able to work under both formulations (small and large rotations, 2D and 3D), I will modify the code.

rukawaaaaaaa commented 9 months ago

@rukawaaaaaaa I think that CI is not able to pass.

@Xiangyu-Hu It is a bit wired that the error messege shows CI is cancelled, should I try it again?

rukawaaaaaaa commented 9 months ago

Thank you! Since the code should be able to work under both formulations (small and large rotations, 2D and 3D), I will modify the code.

@DongWuTUM That will be great. Now the code can not run under both formulations. The angular accleration is in the local current configuration by using the small deformation formulation while that is in local initial configuration by using the large deformation formulation,.

Xiangyu-Hu commented 9 months ago

@rukawaaaaaaa @DongWuTUM I stop the CI as it can not pass before revision.

DongWuTUM commented 8 months ago

@rukawaaaaaaa Please look at the new pull request I created. That you proposed is actually another formulation of shell.

This pull request will be closed, but I noticed that you also changed something for slender structure. Could you please create a new pull request to merge these new changes.

Xiangyu-Hu commented 8 months ago

@rukawaaaaaaa Please look at the new pull request I created. That you proposed is actually another formulation of shell.

This pull request will be closed, but I noticed that you also changed something for slender structure. Could you please create a new pull request to merge these new changes.

@rukawaaaaaaa @DongWuTUM we may consider to include this formulation in the library too.

Xiangyu-Hu commented 8 months ago

the pull request is closed due to another pull request. #413