search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Introduce tinyxml2 parser, other than use xml engine from simbody. #414

Closed DrChiZhang closed 8 months ago

DrChiZhang commented 8 months ago

XML parser based on tinyxml2. Done: Particle restart & reload are implemented. TBD: regression test is not implemented.

Xiangyu-Hu commented 8 months ago

@ChiZhangatTUM There is a case did not pass, probably due to the change of body name?

DrChiZhang commented 8 months ago

@ChiZhangatTUM There is a case did not pass, probably due to the change of body name?

Maybe due to the particle relax and reload parameter setup, I will go to detail this evening.

DrChiZhang commented 8 months ago

@ChiZhangatTUM There is a case did not pass, probably due to the change of body name?

Seems that particle volume is write as zero, I wilk found out the bug.

DrChiZhang commented 8 months ago

The precision of std::to_string is to low, I will change to std::to_chars in the next try.

Xiangyu-Hu commented 8 months ago

XML parser based on tinyxml2. Done: Particle restart & reload are implemented. TBD: regression test is not implemented.

I every thing finished now?

DrChiZhang commented 8 months ago

XML parser based on tinyxml2. Done: Particle restart & reload are implemented. TBD: regression test is not implemented.

I every thing finished now?

In this PR, only the particle writer and reloader is rewritten with the new xml parser to make sure that all work properly, then in the next PR the regression test will be modified with all test data are re-generated.

Xiangyu-Hu commented 8 months ago

XML parser based on tinyxml2. Done: Particle restart & reload are implemented. TBD: regression test is not implemented.

I every thing finished now?

In this PR, only the particle writer and reloader is rewritten with the new xml parser to make sure that all work properly, then in the next PR the regression test will be modified with all test data are re-generated.

How this unfinished things influence the CI tests if one may generate new data set?

DrChiZhang commented 8 months ago

XML parser based on tinyxml2. Done: Particle restart & reload are implemented. TBD: regression test is not implemented.

I every thing finished now?

In this PR, only the particle writer and reloader is rewritten with the new xml parser to make sure that all work properly, then in the next PR the regression test will be modified with all test data are re-generated.

How this unfinished things influence the CI tests if one may generate new data set?

No effect, as the current regression test is using the old xml engine, which is independent on the new xml2 parser.