search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

obvious repeat on define diffusion particles and material #427

Open Xiangyu-Hu opened 8 months ago

Xiangyu-Hu commented 8 months ago

The two lines shows that

https://github.com/Xiangyu-Hu/SPHinXsys/blob/751280b09089f8013abb365386c39ebb73f39099/tests/2d_examples/test_0d_regression_test/regression_test.cpp#L112

and

https://github.com/Xiangyu-Hu/SPHinXsys/blob/751280b09089f8013abb365386c39ebb73f39099/tests/2d_examples/test_0d_regression_test/regression_test.cpp#L201

repeat the use of diffusion material.

Xiangyu-Hu commented 1 month ago

I will revise this by: 1. using single type for all particles, 2. the variables will be registered in diffusion-reaction material or in diffusion reaction methods.