search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Move shell normal update out of relaxation #466

Closed WeiyiVirtonomy closed 6 months ago

WeiyiVirtonomy commented 6 months ago

A separate class for shell normal update is created since normal direction is not used in stress relaxation

WeiyiVirtonomy commented 6 months ago

As far as I see, the only two test cases that use the shell normal direction are _shell_stability_halfsphere and _test_thin_structuredynamics. Please let me know if there are other tests that need to be modified

Xiangyu-Hu commented 6 months ago

You can search the usage by the name of variable. Also as the tests cases should have regression test. If all tests passed, it should be fine.

DongWuTUM commented 6 months ago

Thank you. Yes, you are right. Only two test cases that use the shell normal.

WeiyiVirtonomy commented 6 months ago

I have looked through it. It is quite Okay. Thank you, Weiyi.

Thanks :)