search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Crash with without error message when regression data not written. #469

Open Xiangyu-Hu opened 6 months ago

Xiangyu-Hu commented 6 months ago

The regression test class is defined but not used to output data. For example in the water exit case, one define the test: https://github.com/Xiangyu-Hu/SPHinXsys/blob/d85a5e6683947acd1d7964a636a6bcb1bd6b79d4/tests/2d_examples/test_2d_water_entry_exit/test_2d_water_entry_exit.cpp#L392-L393 But forget to write the output file, and still try to generate the regression test data by: https://github.com/Xiangyu-Hu/SPHinXsys/blob/d85a5e6683947acd1d7964a636a6bcb1bd6b79d4/tests/2d_examples/test_2d_water_entry_exit/test_2d_water_entry_exit.cpp#L538 When I run the python script, I obtained crash information, but not able find the reason, that I actually have not write out data. Therefore, we need an error handler so that one can notice that the data file was not written.

Bo-Zhang1995 commented 6 months ago

I will have a look on that.

Xiangyu-Hu commented 3 months ago

Another issue is that there is repeating data, the the reading the xml lead to error and and the regression data can nor be generated.

Xiangyu-Hu commented 3 months ago

@Bo-Zhang1995 Please look the these bugs.

Bo-Zhang1995 commented 3 months ago

sry forget the previous bug. i will address these asap.- - - - - -张博On 28 Jan 2024, at 13:06, Xiangyu Hu @.***> wrote: @Bo-Zhang1995 Please look the these bugs.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>