search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

revise the continuum dynamics #475

Closed Shuaihao-Zhang closed 5 months ago

Shuaihao-Zhang commented 5 months ago

I revised the continuum dynamics, mainly the following three parts, (1) modified the time integration to obey the position based Verlet scheme. (2) modified the Riemann solver and only applied numerical dissipation on the pressure part. (3) the pressure in the Riemann solver is calculated by the trace of stress tensor rather than using the equation of state, because the plastic deformation will also affect the hydrostatic pressure, while the equation of state only consider the elastic part. The accuracy of the revised version is improved. For example, when modelling the 3D column collapse to study the relationship of run-out distance and the aspect of the column: image The results obtained by the previous version is: image The results obtained by the current version is: image

Shuaihao-Zhang commented 5 months ago

It seems that there is something wrong when installing dependencies on Windows and MacOS.

DrChiZhang commented 5 months ago

Merge master to your branch and PR again. Please also add me as the reviewer, I would like to go through your modification.

DrChiZhang commented 5 months ago

Merge master to your branch and PR again. Please also add me as the reviewer, I would like to go through your modification.

Merge master to your branch and PR again. Please also add me as the reviewer, I would like to go through your modification.

The CI should works after PR #474

Shuaihao-Zhang commented 5 months ago

Merge master to your branch and PR again. Please also add me as the reviewer, I would like to go through your modification.

The CI should works after PR #474

Thanks. I will try again after merging PR #474.

Xiangyu-Hu commented 5 months ago

@Shuaihao-Zhang I think that we need follow strictly the naming convention of SPHinXsys.

Xiangyu-Hu commented 5 months ago

Another thing is that you need update code with new master so that the action will run based on that,

Shuaihao-Zhang commented 5 months ago

@Shuaihao-Zhang I think that we need follow strictly the naming convention of SPHinXsys.

Sure, thanks!

Shuaihao-Zhang commented 5 months ago

Two cases fail on MacOS

_The following tests FAILED: 1 - test_0d_regression_test (Not Run) 15 - test_2d_dambreakpython (Not Run) Error: Process completed with exit code 8.

Xiangyu-Hu commented 5 months ago

I simply rerun and all test passed.