search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 199 forks source link

Function in solid particles never used? #487

Open Xiangyu-Hu opened 5 months ago

Xiangyu-Hu commented 5 months ago

https://github.com/Xiangyu-Hu/SPHinXsys/blob/dce21a0ae44c03a8fce7ef02e70848861054a958/src/shared/particles/solid_particles.h#L98-L131

I am wondering whether these function are used or not. If not, it is better to delete them.

BenceVirtonomy commented 5 months ago

If they are not used, please remove them. Post-processing should not be inside this class in my opinion but completely separated.