search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 197 forks source link

latest version of the code for modelling soils #509

Closed Shuaihao-Zhang closed 3 months ago

Shuaihao-Zhang commented 3 months ago

This is the latest version of the code for modelling soils. This version can reproduce the results in that soil paper:

A Riemann-based SPH method for modelling large deformation of granular materials. link: https://authors.elsevier.com/c/1iP1s,63b-0ODR

I have uploaded this version #486 before, but it has not been approved and there are some conflicts now.

I just solved the conflicts based on #486 and re-upload here.

Shuaihao-Zhang commented 3 months ago

@Xiangyu-Hu @ChiZhangatTUM Please check if there are any other issues. Yesterday, an SPHinXsys user contacted me because he cannot reproduce our results with the current version. With this updated version, users can reproduce the results in the paper.

Shuaihao-Zhang commented 3 months ago

@Xiangyu-Hu @ChiZhangatTUM All CI tests have passed.

Xiangyu-Hu commented 3 months ago

@Shuaihao-Zhang @ChiZhangatTUM the code is merged without addressing my comments?

Shuaihao-Zhang commented 3 months ago

@Shuaihao-Zhang @ChiZhangatTUM the code is merged without addressing my comments?

@Xiangyu-Hu Your comment is addressed. The files riemann_solver_extra.h and riemann_solver_extra.cpp are deleted. And we make the acoustic riemann solver with a construct parameter with default value 3.0 and different value for specific cases.

Xiangyu-Hu commented 3 months ago

@Shuaihao-Zhang sorry that I forgeted to realize my comments. It is still pending.

Xiangyu-Hu commented 3 months ago

@Shuaihao-Zhang could you open a new branch to address the name duplication issue? Thanks.

Shuaihao-Zhang commented 3 months ago

@Shuaihao-Zhang could you open a new branch to address the name duplication issue? Thanks.

Sure. I have created a new branch and a new pull request #511 to solve the naming issues.

Xiangyu-Hu commented 3 months ago

@Shuaihao-Zhang could you open a new branch to address the name duplication issue? Thanks.

Sure. I have created a new branch and a new pull request #511 to solve the naming issues.

Thanks.