search

Xiangyu-Hu / SPHinXsys

SPHinXsys provides C++ APIs for engineering simulation and optimization. It aims at complex systems driven by fluid, structure, multi-body dynamics and beyond. The multi-physics library is based on a unique and unified computational framework by which strong coupling has been achieved for all involved physics.
https://www.sphinxsys.org/
Apache License 2.0
259 stars 197 forks source link

Add New 3D Incompressible Channel Flow Test and Unstructured Mesh Reader #547

Closed Yashmandaokar closed 1 week ago

Yashmandaokar commented 1 month ago

3D Unstructured Mesh Reader (test_3d_unstructured_mesh_reader): Extends the existing mesh reader capabilities to support 3D meshes created from ICEM and Fluent.

3D Incompressible Inviscid Channel Flow Test (test_3d_incompressible_channel_flow): Provides an inviscid channel flow example

Xiangyu-Hu commented 1 month ago

@Yashmandaokar the issue is that the Code need to be compiled in Linux.

Yashmandaokar commented 1 month ago

@Yashmandaokar the issue is that the Code need to be compiled in Linux.

@Xiangyu-Hu. Thank you for bringing this to my attention. Could you kindly advise me on the best approach to address this issue? Should I focus on resolving the errors indicated in the Linux build log, or would it be more effective to attempt compiling the code using a gcc or clang compiler? Your guidance would be greatly appreciated.

Xiangyu-Hu commented 1 month ago

Yes. There should be only small issues, usually due to more strict rules in Linux.

Yashmandaokar commented 3 weeks ago

@Xiangyu-Hu I have rectified the errors. Now the code is compiling on linux. Could you please run the build and test.

Xiangyu-Hu commented 3 weeks ago

You need change ci.yml back to the original as in the master so that the an action will initialized after you make pull request.

Yashmandaokar commented 3 weeks ago

Sorry for he inconvenience. I have changed the Ci.yml back to the original one. Please let me know if anything else needs to be updated. Thank you.

FengWang3119 commented 3 weeks ago

I am curious why there is a class called wavebody in test_3d_incompressible_channel_flow.h. Is it a straight channel?

Xiangyu-Hu commented 3 weeks ago

I am curious why there is a class called wavebody in test_3d_incompressible_channel_flow.h. Is it a straight channel?

I agree with the comment. The naming needs to be expressive and mean what it should.

Yashmandaokar commented 3 weeks ago

I am curious why there is a class called wavebody in test_3d_incompressible_channel_flow.h. Is it a straight channel?

I agree with the comment. The naming needs to be expressive and mean what it should.

I will make the namings expressive and meaningfull. Thank you for your feedback.