change `mymysql` to `go-sql-driver/mysql` - Githubissues

XiaoMi / soar

SQL Optimizer And Rewriter

Apache License 2.0

8.67k stars 1.32k forks source link

change `mymysql` to `go-sql-driver/mysql` #133

Closed martianzhang closed 5 years ago

martianzhang commented 5 years ago

Feature Description

Considering go-sql-driver/mysql keep updating.
use go-sql-driver/mysql buildind FormatDSN for command line xxx-dsn format
get ready for SQL executing with SOAR.
mymysql can't pass go test -race

New branch go-sql-driver for this issue.

Linkyang953 commented 5 years ago

看到目前soar master分支用的是ziutek的mymysql包，go-sql-driver分支用的是go-sql-driver包，请问这两个包各有何利弊，从长期来说soar会选择哪个包作为主要分支的依赖包呢？ @martianzhang