search

XiaoMi / soar

SQL Optimizer And Rewriter
Apache License 2.0
8.67k stars 1.32k forks source link

Make suggestions also in english #8

Open shyim opened 5 years ago

shyim commented 5 years ago

Feature Description

I understand nothing what the suggestions says :)

nerac commented 5 years ago

@shyim you can make use of https://github.com/soimort/translate-shell for now as I do :stuck_out_tongue_closed_eyes:

developerium commented 5 years ago

This feature can make this repo go viral!

CodeBrauer commented 5 years ago

All big projects/repos from china look so interesting, till you want to start and everything is ... chinese.

martianzhang commented 5 years ago

We create a new English branch, but lots of translating work need to do.

https://github.com/XiaoMi/soar/blob/english/advisor/rules_english.go

ghost commented 1 year ago

https://github.com/yassineim/soar

shaedrich commented 9 months ago

We create a new English branch, but lots of translating work need to do.

https://github.com/XiaoMi/soar/blob/english/advisor/rules_english.go

Shouldn't this preferrably be the default rules file (as it's done in https://github.com/yassineim/soar/blob/dev/advisor/rules.go)?

Ideally, let's already create a PR (even if it might be a draft for now) for this so we can comment on it

(related to #30)