search

XiaoTaoWang / NeoLoopFinder

A computation framework for genome-wide detection of enhancer-hijacking events from chromatin interaction data in re-arranged genomes
Other
53 stars 16 forks source link

Numpy.int AttributeError #45

Open TeoSakel opened 1 year ago

TeoSakel commented 1 year ago

The following line raises an attribute error for new versions of numpy: https://github.com/XiaoTaoWang/NeoLoopFinder/blob/b7587c90d1f20383b62a96f8281e4ba397101a98/neoloop/callers.py#L822

Error message:

AttributeError: module ‘numpy’ has no attribute ‘int’.
`[np.int](http://np.int/)` was a deprecated alias for the builtin `int`. To avoid this error in existing code, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `[np.int](http://np.int/)`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
  https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: ‘inf’?

I freshly installed it with conda as described in the install section of the ReadMe.

Perhaps np.int should be changed to np.int64?

XiaoTaoWang commented 1 year ago

Thanks for this feedback! I have just made this change in the latest 0.4.3.post2 version, can you upgrade your NeoLoopFinder to this version (pip install -U neoloop) and let me know whether it works?