box offset of eraser in PCNet-M

XiaohangZhan / deocclusion

Code for our CVPR 2020 work.

Apache License 2.0

795 stars 104 forks source link

box offset of eraser in PCNet-M #12

Closed zzw1123 closed 4 years ago

zzw1123 commented 4 years ago

Hi, I think the offset here https://github.com/XiaohangZhan/deocclusion/blob/c8439ea5c119ec1d2cfab5f8ba4694de88e5b0b4/utils/data_utils.py#L90 should be bbox = (int(offx w), int(offy h), w, h). Is it a bug?

XiaohangZhan commented 4 years ago

Actually h always equals to w here, since the input inst is always square, see https://github.com/XiaohangZhan/deocclusion/blob/c8439ea5c119ec1d2cfab5f8ba4694de88e5b0b4/datasets/partial_comp_dataset.py#L86. However, it's better to fix it to avoid misleading. I will fix it soon, thank you!

zzw1123 commented 4 years ago

Got it. Thank you!