search

XiaomiFirmwareUpdater / xiaomi-flashable-firmware-creator

Xiaomi Flashable Firmware Creator
https://xiaomifirmwareupdater.com/projects/xiaomi-flashable-firmware-creator/
GNU General Public License v3.0
148 stars 43 forks source link

Remove metadata.pb from firmware files #57

Closed yshalsager closed 1 year ago

yshalsager commented 1 year ago

Error while flashing vayu latest global firmware:

current sp:2022-07-05 Target SPL: 2022-07-01 this is considered a downgrade deying OTA because it's spl downgrade
erdnaxe commented 1 year ago

This bug makes it impossible to upgrade Xiaomi firmware from LineageOS recovery. TWRP seems to skip this check.

To upgrade to LineageOS 19 (on miatoll device), I had to flash TWRP, flash the firmware update package then flash back LineageOS recovery.

Is there a reason for not stripping this from the firmware update? Should I try to propose a patch for this repository to automatically remove metadata.pb from upgrade packages?

yshalsager commented 1 year ago

This bug makes it impossible to upgrade Xiaomi firmware from LineageOS recovery. TWRP seems to skip this check.

To upgrade to LineageOS 19 (on miatoll device), I had to flash TWRP, flash the firmware update package then flash back LineageOS recovery.

Is there a reason for not stripping this from the firmware update? Should I try to propose a patch for this repository to automatically remove metadata.pb from upgrade packages?

It was included by default, ~I will try to find time to remove it soon~, contributions are welcome :)

Edit: Done.