XiaomiFirmwareUpdater / xiaomi-flashable-firmware-creator

Xiaomi Flashable Firmware Creator
https://xiaomifirmwareupdater.com/projects/xiaomi-flashable-firmware-creator/
GNU General Public License v3.0
149 stars 45 forks source link

xiaomi-flashable-firmware-creator exits with "is not a valid ROM file." #7

Closed IeP4nieF closed 4 years ago

IeP4nieF commented 4 years ago

Hi!

I tried to create a flashable ROM (firmware + vendor) for tissot. I used this ROM to achive this.

https://xiaomifirmwareupdater.com/miui/tissot/

(checked both versions, fastboot an recovery)

   $ xiaomi_flashable_firmware_creator -V miui_TISSOT_V10.0.24.0.PDHMIXM_bcbbe1fad4_9.0.zip
    Traceback (most recent call last):
      File "$HOME/.local/bin/xiaomi_flashable_firmware_creator", line 10, in <module>
        sys.exit(main())
      File "$HOME/.local/lib/python3.7/site-packages/xiaomi_flashable_firmware_creator/xiaomi_flashable_firmware_creator.py", line 39, in main
        firmware_creator = FlashableFirmwareCreator(zip_, process, output)
      File "$HOME/.local/lib/python3.7/site-packages/xiaomi_flashable_firmware_creator/firmware_creator.py", line 60, in __init__
        self.init()
      File "$HOME/.local/lib/python3.7/site-packages/xiaomi_flashable_firmware_creator/firmware_creator.py", line 89, in init
        f"{self.input_file} is not a valid ROM file. Exiting..")
    RuntimeError: miui_TISSOT_V10.0.24.0.PDHMIXM_bcbbe1fad4_9.0.zip is not a valid ROM file. Exiting..

Of course I used the newest Version of xiaomi-flashable-firmware-creator from git.

Expected behaviour: Create a flashable zip-file.

yshalsager commented 4 years ago

Unfortunately, Android One devices ROMs aren't supported since it doesn't have updater-script file and use payload.bin instead of the standard zip scheme.

IeP4nieF commented 4 years ago

Ok, thanks for the explanation.

Perhaps it should be mentioned under the FAQ (https://xiaomifirmwareupdater.com/faq/), that Android One devices are not supported.

BTW: An explanation what the difference between firmware and vendor zips are, would be also good, in the FAQ. As far as I can see, the vendor-images contains the firmware with addition of boot and vendor. So why should someone install the firmware-package?

yshalsager commented 4 years ago

@IeP4nieF Actually supported devices are listed here https://xiaomifirmwareupdater.com/supported/firmware

Yeah you're right. Flashing firmware only is the default since not all custom roms ship vendor.