Xiaoven / codegex

A light-weight tools like spotbugs
GNU Lesser General Public License v2.1
1 stars 0 forks source link

False negatives #166

Open Xiaoven opened 3 years ago

Xiaoven commented 3 years ago

DM_INVALID_MIN_MAX

  1. We hasn't supported number like "1D" yet.

jmh: org/openjdk/jmh/profile/LinuxPerfNormProfiler.java

multiplier = Math.max(1D, Math.min(0D, multiplier));

NM_CLASS_NAMING_CONVENTION

  1. Not support enum yet. biojava: org/biojava/nbio/core/sequence/location/InsdcParser.java
enum complexFeaturesAppendEnum {

BIT_SIGNED_CHECK

  1. Lack type message. We are more strict and require there are at least one constant to indicates type.

I think & can indicate the type message, at least the operands are integer.

biojava: UncompressInputStream.java

if ((header & HDR_EXTENDED) > 0)
zhouyinn commented 3 years ago

ES_COMPARING_STRINGS_WITH_EQ

@Override
    public boolean equals(Object obj)
      {
        if(obj == this) return true;
        if(!(obj instanceof Term)) return false;

        Term that = (Term) obj;

        return this.getOntology() == that.getOntology() &&
                this.getName() == that.getName();
      }
    }