XierHacker / LearningTensorFlow

Tensorflow 2.0 Tutorials
119 stars 42 forks source link

Performance issues in /Project (by P3) #3

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello! I've found a performance issue in /Project: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

Besides, you need to check the function called in map()(e.g., _parse_data called in dataset.map(map_func=_parse_data)) whether to be affected or not to make the changed code work properly. For example, if _parse_data needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented 3 years ago

Hello, I'm looking forward to your reply~