search

Xilef11 / Runes-of-Wizardry

Magical mod for the game of Minecraft.
GNU General Public License v3.0
6 stars 4 forks source link

rune of lumber issues #19

Open Crazy-KSK opened 8 years ago

Crazy-KSK commented 8 years ago

The rune of lumber particles are far too large it completely fills the screen with vanilla explosions.

Using it in a large forrest causes a lot of lag and might crash/stall on a lesser pc

It leaves quite a bunch of trees halve cut at the edges and some floating blocks on larger trees http://i.imgur.com/9ylG91Y.jpg

The rune doesn't turn grey completely after completing maybe related to mine craft running slow when it breaks a blocks http://i.imgur.com/h6SbODt.png http://i.imgur.com/SQEe6bW.png

Forge 12.17.0.1954 Runes-of-Wizardry-1.9.4-0.6.5

Xilef11 commented 8 years ago

I'll look into shrinking the particles (good to know that they're actually working now though) lag - not much can be done i'm afraid tree halves - i'll investigate, its probably related to the max range of the rune rune not turning grey - try relogging, it's probably a client-server desync (even in single player). I've experienced it a few times and can't figure out what's causing it

Xilef11 commented 8 years ago

I tuned down the particles, it should be better now. the lag is probably caused by recursively chopping all trees in a single tick. I can probably distribute that over a few ticks, but that will take a bit of work. It looks like the tree remains are there because they have leaves in the range of the rune (or connected to some that are), but their trunks are not. managing this becomes a design decision: I can't chop the trees if their leaves are within the range of the rune, because that would (probably) try to chop down the whole forest. I could probably, however, make the rune stop square at its range (which I find ugly), as well as a few variations on that. Feedback would be nice on this one.

Crazy-KSK commented 8 years ago

how about you make it a square area but only chop the wood and propagate along wood that's at the edge of the area, in a 3x3 cube centered on each wood piece then chop those, so no halve trees are left and then speed up leave decay in the area that way there would be no hard leave edges, basically thaumcraft-axe's all trees in the area

Xilef11 commented 8 years ago

I increased the vertical range of the rune, and made sure only leaves in the range get chopped (I have no clue how to speed up leaf decay). This leaves hard leaf edges if a tree in the radius has leaves outside of it or if a tree outside has leaves inside, but there should not be missed tree blocks (unless there is a tree that starts in the range but extends for more than 16 blocks outside of it). 2016-06-14_11 53 38

Crazy-KSK commented 8 years ago

cool I can't seem to get runesofwizardry-classics-master to build though its complaining about packages not existing

Xilef11 commented 8 years ago

You need a deobf jar of Runes of Wizardry in a "libs" folder at the root of the project. I pushed a release today that includes the changes, so you shouldn't have to build it yourself.

Crazy-KSK commented 8 years ago

ah thanks. Rune of lumber is a lot less laggy now!

Edit: oh I just got this idea: if there is a way to check if a leave is decaying; you could chop the wood only and then all the leaves that are decaying as a result of the wood missing. That would give the same result as speeding up decay.