search

Xilef11 / runesofwizardry-classics

Reimplementation of the classic (Runic dusts mod) dusts and runes with Runes of Wizardry
GNU General Public License v3.0
5 stars 1 forks source link

Protection Rune #11

Closed scottosx closed 7 years ago

scottosx commented 7 years ago

In 1.10.2 the tooltip says on 1xSpawn for a sacrifice. Not sure what it wants here. In your source it looks like it wants a Villager egg. That doesn't work for me yet. A villager either, or hostile/passive mob. Confused.

Xilef11 commented 7 years ago

a villager egg is the correct sacrifice, but it won't work because spawn eggs changed (from metadata to NBT) between 1.9 and 1.10, and I forgot to update that part until 1.12. I'm not sure if it's worth backporting the fix since 1.10 is pretty much EOL now...

scottosx commented 7 years ago

1.10.2 is the current standard for mod packs for the time being. Simply Magic 2 for instance can give more exposure to your mod. Surely not a heavy-lift fix?

Xilef11 commented 7 years ago

try v1.10.2-0.4.3-b1 (it should also be on Curse soon)

Please note that this is the maximum effort I'm willing to put in 1.10.2. I can't support old versions forever and modpacks will need to catch up to MC versions if they want the latest features and fixes.

scottosx commented 7 years ago

Thanks for the update. I had this crash on load however:

crash-2017-08-23_11.23.16-client.txt

Xilef11 commented 7 years ago

try this one

scottosx commented 7 years ago

This version launches fine. Protection rune works too, accepting a villager egg. Thank you very much.

Quick question, protection doesn't require Power Distributor does it? Source seems to have a commented out reference. And which runes do require power?

Xilef11 commented 7 years ago

It should not require fuel. (the power distribution rune is just an easy way to fuel multiple runes without having to drop fuel on each of them individually). runes that require fuel will usually have that information documented (tooltip of the runic dictionnary when you hold shift) as "lasts XX unless fueled"