Missing pixels in playback controls - Githubissues

XilinJia / Podcini

Open source podcast player for Android in Kotlin with androidx.media3

GNU General Public License v3.0

111 stars 5 forks source link

Missing pixels in playback controls #27

Closed ls-2020 closed 3 months ago

ls-2020 commented 3 months ago

Checklist

[X] I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
[X] I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
[X] I will describe the problem with as much detail as possible.
[X] If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

4.5.1(free)

Where did you get the app from

github

Android version

13 (LOS 20)

Device model

No response

First occurred

No response

Steps to reproduce

none required, this happens always

Expected behaviour

playback-button-area should be completely visible

Current behaviour

playback-button-area is cut-off (half of the text-descriptions below the buttons "1.00" "15" "15" are missing) see attached screenshot (below this area are the three main android-navigation-buttons which are not visible in the screenshot) if i click on the podcast image which opens the details page there is no cut-off (in all other views the playback-button-area is "cut-off")

Screenshot_20240402

Logs

No response

XilinJia commented 3 months ago

Ohm, this is pretty strange. On my 2 phones there is no such problem. Added a bit bottom margin to the numbers. Let's see if it helps, in the coming release.

ls-2020 commented 3 months ago

this did not help. there is no difference between 4.5.1 and 4.5.2 (maybe you have to test it with bigger font-size in android-settings?)

i think the whole container for image, buttons and time-progress is not aligned correctly and should be moved up. (as mentioned above only in the podcast-view everything is placed correctly without cut-off)

XilinJia commented 3 months ago

did some further adjustments in 4.5.3. Please test it.

ls-2020 commented 3 months ago

in 4.5.3 something changed: <4.5.3 the podcast-view was OK and the other views were cut-off now the podcast-view is cut-off as well and now all views have identical cut-off and the cut-off is not as big as before, but there are still few pixels missing at the bottom (it's an improvement)

so either more space at the bottom is required or you revert the changes and try to align the container in the main-view the way you aligned the container in the podcast-view <4.5.3

XilinJia commented 3 months ago

"<4.5.3 the podcast-view was OK and the other views were cut-off" what do you mean by this? Your screenshot was with Episodes view and you saw the cutoff, but with you change the view to Podcast from Episodes, then there was no cutoff? I don't see how that can be different. I am making a test version with a bit larger height. Could you try it in a while?

XilinJia commented 3 months ago

here you go: https://github.com/XilinJia/Podcini/releases/tag/4.5.3.test

ls-2020 commented 3 months ago

it is way better but still not fixed! the text is not cut-off anymore, but few pixels at the bottom of the image are missing, so height should still be a bit larger!

yes, in <4.5.3 in the details of the episode (description/shownotes + large image) there was no cut-off so the controls looked different in the normal view and in the details (i tried to describe this in the screenshot: "click on image...")

XilinJia commented 3 months ago

It should be before 4.5.2 where the player controls for detailed view and the collapsed view are handled differently. Since 4.5.2, it's all merged into one class.

The height of the player control is awkwardly restricted by a few things that might result in some mismatching. I would keep it for now unless we see bigger issues.

ls-2020 commented 3 months ago

yes, i understand and it is no big issue anymore, but maybe just give it again a bit more height (the text has no margin to android-buttons)