XilinJia / Podcini

Open source podcast instrument for Android in Kotlin with media3, supporting YouTube channels.
GNU General Public License v3.0
152 stars 6 forks source link

Disabling "Pause for interruptions" does not have an effect #69

Open PatrykMis opened 1 month ago

PatrykMis commented 1 month ago

Checklist

App version

6.0.9

Where did you get the app from

GitHub Releases

Android version

14 QPR3, GrapheneOS

Device model

Google Pixel 8

First occurred

In v5.x or earlier, I haven't checked it on earlier versions than v5.

Steps to reproduce

  1. Play the podcast. By default this feature is on, so if TalkBack (screen reader) starts talking, or the user receives a notification from another app, the playback pauses until that notification sound finishes or TalkBack stops talking.
  2. Go to settings and disable pause for interruptions.
  3. Play any podcast. The playback sound should be quieter when another app or system starts emitting sound, but it's still pausing.

In upstream AntennaPod, this setting works as expected. In my opinion, it's something regarding migration to AndroidX Media3; I will try to check the code and Media3 docs but I'm not an expert.

Expected behaviour

The playback sound should be quieter when another app or system starts emitting sound while this setting is disabled.

Current behaviour

The playback is still pausing while this setting is disabled.

Logs

No response

PatrykMis commented 1 month ago

update: it appears to be intentional, I wasn't able to find a code to handle this case yet, maybe it's in progress and will be added after migration-related work will be finished and migration will be fully working.

XilinJia commented 1 month ago

I think currently all audio focus handling relies on media3. I may visit this for any possible workaround later, but any PR is welcome on this.