search

XilinJia / Podcini

Open source podcast instrument for Android supporting contents from YouTube and YT Music as well as normal podcasts.
GNU General Public License v3.0
207 stars 8 forks source link

Fixed bug in nextcloud auth #94

Closed Dacid99 closed 1 month ago

Dacid99 commented 1 month ago

The issue was that the browser intent runs on its own thread and so the poll() method is called without waiting for the browser activity to finish. So as the token is not authenticated yet, this leads to the 404. I moved this call to poll() to a method that is called when the app resumes after the browser is finished. All my tests work now, so this resolves #49

XilinJia commented 1 month ago

Thanks. Will merge shortly.

Dacid99 commented 1 month ago

I wouldnt know how to resolve this, there is no develop branch that i can see

XilinJia commented 1 month ago

I wouldnt know how to resolve this, there is no develop branch that i can see

Sorry, that's not an issue. Looks like some snyk checks are not necessary.

Dacid99 commented 1 month ago

Perfect, thanks

XilinJia commented 1 month ago

@Dacid99 merge successful, but for some reason you are not added by Github to the contributors. I will sort it out.

XilinJia commented 1 month ago

I forcibly added you via a commit message "Co-authored-by: PR Author Name Dacid99@users.noreply.github.com". I'm not sure about the reason why you were not automatically added by Github, does it have to do with your email configuration at github?

Dacid99 commented 1 month ago

Ill look into it, thanks a lot for sorting this out, I probably wouldnt even have noticed