search

Xilinx-CNS / onload

OpenOnload high performance user-level network stack
Other
575 stars 95 forks source link

Onload DKMS fail to build in Ubuntu 24.04 #219

Closed zaufi closed 5 months ago

zaufi commented 6 months ago

I know it's not officially supported (yet?) but maybe smbd knows how to fix this?


/var/lib/dkms/openonload/8.1.2.26/build/build/x86_64_linux-6.8.0-31-generic/driver/linux_net/drivers/net/ethernet/sfc/ethtool.c:546:35: error: initialization of ‘int (*)(struct net_device *, struct ethtool_rxfh_param *)’ from incompatible pointer type ‘int (*)(struct net_device *, u32 *, u8 *, u8 *)’ {aka ‘int (*)(struct net_device *, unsigned int *, unsigned char *, unsigned char *)’} [-Werror=incompatible-pointer-types]
  546 |         .get_rxfh               = efx_ethtool_get_rxfh,
      |                                   ^~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/openonload/8.1.2.26/build/build/x86_64_linux-6.8.0-31-generic/driver/linux_net/drivers/net/ethernet/sfc/ethtool.c:546:35: note: (near initialization for ‘efx_ethtool_ops.get_rxfh’)
/var/lib/dkms/openonload/8.1.2.26/build/build/x86_64_linux-6.8.0-31-generic/driver/linux_net/drivers/net/ethernet/sfc/ethtool.c:547:35: error: initialization of ‘int (*)(struct net_device *, struct ethtool_rxfh_param *, struct netlink_ext_ack *)’ from incompatible pointer type ‘int (*)(struct net_device *, const u32 *, const u8 *, const u8)’ {aka ‘int (*)(struct net_device *, const unsigned int *, const unsigned char *, const unsigned char)’} [-Werror=incompatible-pointer-types]
  547 |         .set_rxfh               = efx_ethtool_set_rxfh,
      |                                   ^~~~~~~~~~~~~~~~~~~~```
ivatet-amd commented 6 months ago

@zaufi Thank you for raising the issue. 👍

Could you check if the latest OpenOnload master works for you? I think this specific Netdriver kernel compat fix went into master with https://github.com/Xilinx-CNS/onload/commit/c552f701dc2f4fe5ea44878674d6c817a6ed82e9 and is scheduled for the next Onload 8.1 release.