search

Xilinx-CNS / tcpdirect

AMD TCPDirect ultra low latency kernel bypass TCP and UDP implementation for AMD Solarflare network adapters, to be used with corresponding versions of Onload®️ at https://github.com/Xilinx-CNS/onload. The stable branch is currently `v8_1`.
22 stars 17 forks source link

Cleanup: Actually build ndebug when building from installed packages #44

Closed tcrawley-xilinx closed 2 months ago

tcrawley-xilinx commented 2 months ago

Previously zf_mkdist would just rm certain sub-directories from build tree before starting a different build type. This was fine when all builds used an onload tarball. However, now that tcpdirect can be built against a system installed onload this can cause issues as these subdirectories don't necessarily exist. This can be resolved by rm-ing the entire build directory and continuing from that point.

Testing done

Manual inspection. Previous when calling zf_mkdist it would say that it was build ndebug binaries, but then make would say nothing to be done for all (or similar) and grepping for -DNDEBUG in the build logs wouldn't get anything. Now the NDEBUG builds are actually happening

pcolledg-amd commented 2 months ago

Could make clean?

tcrawley-xilinx commented 2 months ago

Could make clean?

Unfortunately doesn't work when building from an onload tarball

abower-amd commented 2 months ago

Could make clean?

Unfortunately doesn't work when building from an onload tarball

Better be careful we don't accidentally remove some intermediate content that is used for debug packages or debian metadata.