search

Xilinx / ACCL

Alveo Collective Communication Library: MPI-like communication operations for Xilinx Alveo accelerators
https://accl.readthedocs.io/
Apache License 2.0
82 stars 26 forks source link

Move secondary includes in seperate subdir #109

Closed TristanLaan closed 2 years ago

TristanLaan commented 2 years ago

Move secondary includes to accl subdir to prevent bloating the include space with common names like 'common.hpp', which could result in naming conflicts with user files. Leaving accl.hpp in the main folder makes it easier for users to include (#include <accl.hpp> vs #include <accl/accl.hpp>) and makes sure users don't have to change the include of current applications.

Mellich commented 2 years ago

I think you forgot one.

HLS test does not compile.

TristanLaan commented 2 years ago

I think you forgot one.

HLS test does not compile.

Whoops you're right, will fix.