Xilinx / ACCL

Alveo Collective Communication Library: MPI-like communication operations for Xilinx Alveo accelerators
https://accl.readthedocs.io/
Apache License 2.0
81 stars 26 forks source link

Updated driver device files to select args to pass based on scenario #175

Closed mar-ven closed 9 months ago

mar-ven commented 9 months ago

Modified coyotedevice.cpp and fpgadevice.cpp in driver/xrt/src to specifiy which args to pass based on scenario. Added the header file commands.hpp in driver/xrt/include/accl to specify the arg id for fpgadevice.cpp args. Previous implementation automatically increased arg id by 1, but now some args are skipped based on scenario, so arg value must be provided explicitly.

mar-ven commented 9 months ago

I moved the definitions into constants.hpp and used the namespace XRT_ARG_ID to embed them, in order to be consistent with the content of that header file