search

Xilinx / ACCL

Alveo Collective Communication Library: MPI-like communication operations for Xilinx Alveo accelerators
https://accl.readthedocs.io/
Apache License 2.0
81 stars 26 forks source link

Fix extdma and kernel connections issues. #191

Closed bo3z closed 4 months ago

bo3z commented 4 months ago

This PR attempts to fix two issues, observed when synshteising ACCL with TCP/IP and (vadd, but possibly other) kernels.

  1. The gen_files.py for external DMA by default includes TDEST signals. However, these are not always present (i.e. not present when there is one port as verified by the script bd.tcl).
  2. The kernels lack stream connections to the CCLO. This is solved in a similar way to the DLRM example for OSDI, where the second hostctrl (per CCLO) is removed and those connections are used for the kernels. I am not sure if this causes any change for other applications.

This passes synthesis. I am currently testing PnR and will test on actual hardware in the following days, but the changes here should have no impact on fucntionality.