Xilinx / KRS

The Kria Robotics Stack (KRS) is a ROS 2 superset for industry, an integrated set of robot libraries and utilities to accelerate the development, maintenance and commercialization of industrial-grade robotic solutions while using adaptive computing.
https://Xilinx.github.io/KRS/
Other
46 stars 18 forks source link

KRS alpha release is wrong #16

Closed vmayoral closed 2 years ago

vmayoral commented 2 years ago

@jasvinderkhurana this has been around for a few weeks now and nobody with privileges has reacted just yet. KRS was released a month ago and still, other than in the fork that I'm maintaining, the official repo (this one) does not have a proper alpha release.

Let's correct the KRS alpha release. Current one is wrong. Please use content from https://github.com/vmayoral/KRS/releases/tag/alpha. Feel free to retag things at the current HEAD of the repo and re-release it adding https://github.com/Xilinx/KRS/blob/main/krs.repos to the release files for visibility.

jasvinderkhurana commented 2 years ago

@vmayoral Sorry, for the delay! I just did the alpha release!

vmayoral commented 2 years ago

@jasvinderkhurana, as pointed out above, can we please correct the release's krs.repos file and use https://github.com/Xilinx/KRS/blob/main/krs.repos?

You're using an older version which doesn't account for recent changes (we'll need to stay tuned to new tags on repos and make updates/minor additional releases, e.g. alpha1, alpha2, etc.). For now, for consistency (since the tag points out to current main branch with that file included), can we just update (manually is easy) the krs.repos you included with https://github.com/Xilinx/KRS/blob/main/krs.repos?

For future pre-releases, if you agree, let's coordinate through a ticket (this way) and we'll plan the release notes and everything around minor releases.

jasvinderkhurana commented 2 years ago

@vmayoral , I used the latest krs.repos only which was updated 4 days ago and has the below content:

repositories:
  acceleration/acceleration_firmware:
    type: git
    url: https://github.com/ros-acceleration/acceleration_firmware
    version: 0.4.0
  acceleration/acceleration_firmware_kv260:
    type: zip
    url: https://github.com/ros-acceleration/acceleration_firmware_kv260/releases/download/v0.6.0/acceleration_firmware_kv260.zip
  acceleration/colcon-acceleration:
    type: git
    url: https://github.com/ros-acceleration/colcon-acceleration
    version: 0.2.0
  acceleration/ros2acceleration:
    type: git
    url: https://github.com/ros-acceleration/ros2acceleration
    version: 0.2.0
  acceleration/ament_vitis:
    type: git
    url: https://github.com/ros-acceleration/ament_vitis
    version: 0.5.0
  acceleration/vitis_common:
    type: git
    url: https://github.com/ros-acceleration/vitis_common
    version: 0.1.0

If I have still missed anything, please let me know and we can fix it.

vmayoral commented 2 years ago

@jasvinderkhurana, I downloaded again https://github.com/Xilinx/KRS/releases/download/alpha/krs.repos (which comes from the release you created) and shows the following:

repositories:
  acceleration/acceleration_firmware:
    type: git
    url: https://github.com/ros-acceleration/acceleration_firmware
    version: 0.4.0
  acceleration/acceleration_firmware_kv260:
    type: zip
    url: https://github.com/ros-acceleration/acceleration_firmware_kv260/releases/download/v0.6.0/acceleration_firmware_kv260.zip
  acceleration/colcon-acceleration:
    type: git
    url: https://github.com/ros-acceleration/colcon-acceleration
    version: 0.1.0
  acceleration/ros2acceleration:
    type: git
    url: https://github.com/ros-acceleration/ros2acceleration
    version: 0.2.0
  acceleration/ament_vitis:
    type: git
    url: https://github.com/ros-acceleration/ament_vitis
    version: 0.5.0
  acceleration/vitis_common:
    type: git
    url: https://github.com/ros-acceleration/vitis_common
    version: 0.1.0

This is still wrong. It needs to be updated.

jasvinderkhurana commented 2 years ago

@vmayoral , this is really strange we both are getting different versions. Let's sync up once to fix this.

vmayoral commented 2 years ago

@jasvinderkhurana my bad, I didn't check properly, the updates 21 hours ago fixed this file.

All good.

jasvinderkhurana commented 2 years ago

@vmayoral thanks for the update!