Closed vmayoral closed 2 years ago
@methylDragon, @luca-della-vedova I brought this information in here to continue tracking progress.
Reviewed the progress and added the dependency between ament_acceleration
and ament_vitis
. Let me know if you have any additional input!
@methylDragon, on https://github.com/ros-acceleration/tracetools_acceleration/issues/1#issuecomment-1081891662 a PR would be appreciated (if needed).
Fulfilled for all repos http://wiki.ros.org/buildfarm/Pull%20request%20testing
Nice!! I'll be doing the releases enabling PR testing moving forward then
On Wed, 30 Mar 2022, 07:16 Víctor Mayoral Vilches, @.***> wrote:
Fulfilled for all repos http://wiki.ros.org/buildfarm/Pull%20request%20testing
— Reply to this email directly, view it on GitHub https://github.com/Xilinx/KRS/issues/53#issuecomment-1083195759, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2TVRV6DOIQOYFYQX357PDVCROZ7ANCNFSM5R6N3R5Q . You are receiving this because you were mentioned.Message ID: @.***>
Reviewed package status and updated things accordingly above.
Looking further into colcon-hardware-acceleration
.
All right, I think we're getting there. For the sake of alignment, thinks that I can track and are left:
vitis_common
WIP https://github.com/ros/rosdistro/pull/32671ament_acceleration
pending PRs seem merged https://github.com/ros-acceleration/ament_acceleration/issues/1#issuecomment-1086201266, are we waiting for something else in here? Can we ask for re-trigering the build maybe? If so, is there an easy way for me to do it?Looking at Humble Freeze dates @methylDragon, anything that concerns you at this stage to make it safely?
We have until May 19 and most of the packages are already merged into rosdistro
. There shouldn't be any issues unless vitis_common
has binary build failures. Syncs will happen and don't require us to fit the package in after the deadline (the deadline just means the packages have to be frozen.)
The release for adaptive_component
will be a bit tighter though, especially if we want to make time to make sure it's really robust.. But in principle if we just want a release, it can follow the same sort of process as per the packages we've released so far.
All right, it appears only package 1
is left to be completed with the overall KRS core packages release.
@methylDragon do we have any updates on?
- colcon-hardware-acceleration has been pushed to https://pypi.org/project/colcon-hardware-acceleration/ but there're two new tags. The latest one at https://github.com/colcon/colcon-hardware-acceleration/pull/15. Important, I don't have privileges to merge this PR nor to push directly to this repo after the migration. Can we address all these so that we can submit 0.7.0 to PyPI?
No updates here, unfortunately.. The colcon
team doesn't have capacity dedicated to this, so any support we get from them is from review time, that I've been trying to push for. This is for both PyPI and packagecloud.
The bizdev side people might be better to ask for progress on getting that maneuvered around, but we should be able to meet the humble freeze (also, the package is already available on PyPI anyway.)
But in the meantime I'll ping the colcon
team to see if we can be added as maintainers.
What I'm more concerned about is whether we'll be able to get the acceleration nodes merged by the time. Would it be possible to start looking into those issues? I haven't been able to fully test the boards/run through the testing tutorials yet.
No updates here, unfortunately.. The colcon team doesn't have capacity assigned to this, so any support we get from them is from review time, that I've been trying to push for. This is for both PyPI and packagecloud.
Ok thanks.
To get clarity on my side and report back, does this mean that (both for now and future contributions) the bottleneck of colcon-hardware-acceleration
contributions and PR reviews will be the colcon team? If so, and no access/privileges are given to us after transferring the repo, doesn't this mean that effectively, this repo will be maintained by the colcon team?
Maybe I misunderstood something in here, but this wasn't intended.
What I'm more concerned about is whether we'll be able to get the acceleration nodes merged by the time. Would it be possible to start looking into those issues? I haven't been able to fully test the boards/run through the testing tutorials yet.
What do you mean by "to get the acceleration nodes merged by the time"? The instructions that I have is for me to work with you guys to meet the objectives above (milestone 1
) before anything else. Happy to support you while trying to run the acceleration examples if you're encountering problems. If so, could you open tickets with the corresponding issues (e.g. within acceleration_examples)?
Note that these examples aren't meant to be released in Humble/Rolling just yet.
I'm trying to get us added as maintainers, I think it'll be better for both the colcon team and the hardware-acceleration-wg in that case.
But for now there are no new actionables aside from waiting for colcon, and for the sync and making sure the currently released packages get propagated to the public repos.
Let's start working on the hardware acceleration nodes in the meantime.
There's a couple of information gathering issues asking about the intention currently and moving forward for certain decisions made in the implementation of adaptive_component
. Should we track this in a separate issue?
Ok, both of us should be added as maintainers on the colcon org's hwa team! I've merged the PR accordingly.
@vmayoral , would you like to try doing the PyPI release?
Thanks @methylDragon, uploaded 0.7.0
and confirmed I have privileges in both the repo and PyPI.
AFAIK, this wraps all items above for releasing key KRS repos. A few open questions:
colcon-hardware-acceleration
? Should we be doing releases in here as well? Hi @vmayoral ,
humble
once humble
is released, but aside from that there is nothing for us to do except to wait! The blooming process should be relatively simple since most of the package configs should be good to go. Fingers crossed that we don't get any CI surprises.apt install
them). This will need to wait for a sync, and those tend to come around once a month.
As for packagecloud... The colcon team is trying to get the permissions to add us as maintainers to the colcon org's packagecloud. I think you can give them some time, and once they get those permissions, you can run this command to push to it instead (making sure to edit publish-python.yaml
to point to the colcon org's packagecloud repo):
./bin/publish-python -upload stdeb:packagecloud
If they can't get the permissions, I think they'll look for a workaround. I'm not sure about the timeline for this.
All right, thanks. That clarifies a lot. I'll annotate then the checkboxes above to reflect pending things accordingly.
There might be a rolling sync by the end of this week, let's keep a look out!
Rolling sync is started: https://discourse.ros.org/t/preparing-for-rolling-sync-2022-04-12/25091
There is a hold on new rolling releases (so adaptive_component
will have to wait till the sync is done.)
I can see @methylDragon that we're full-green now (e.g. http://repo.ros2.org/status_page/ros_rolling_default.html?q=ament_acceleration) but I did a quick check searching in Open Robotics ROS 2 apt repository and couldn't find these in Rolling (ros-rolling-*
).
Maybe my expectation was wrong and there're some additional steps needed in the process until these become ready?
We need to wait for the sync to complete. It usually takes about a week or so, but our packages are in already.
See the new package list
If you can, confirm all the packages we've released are there. I see them.
I see some references in the source list:
Oh, also, rolling package releases on Linux only target Jammy if I'm not wrong. Try it out on a Jammy machine?
I see our packages in:
But not in (expected):
adaptive_component
should be in rolling
after this sync
Colcon package is up on http://repo.ros2.org/status_page/rolling_default.html and http://repo.ros2.org/status_page/humble_default.html !!
Now we're only waiting for a humble sync for our rolling packages (other than colcon) and we should be done!
Thanks everyone for the effort in here!
This ticket follows from https://github.com/ros2-gbp/ros2-gbp-github-org/pull/22#issuecomment-1073811491 and tracks the progress of releasing into the official ROS 2 buildfarm generic hardware acceleration-related KRS ROS packages.
ping @methylDragon, @luca-della-vedova. Please me keep this updated.
Hardware acceleration packages release status
package 1
: colcon-accelerationcolcon
team to review package name and general approach https://github.com/colcon/colcon-core/issues/493#issuecomment-1071350845publish-python.yaml
file to define the release process https://github.com/ros-acceleration/colcon-hardware-acceleration/blob/main/publish-python.yamlcolcon-core
colcon/colcon-core
to request for this repo to be transferred into thecolcon
org (https://github.com/colcon/colcon-core/issues/493)package 2
: ament_accelerationpackage.xml
@vmayoralbloom
release https://github.com/ros2-gbp/ament_acceleration-releasebloom
should PRrosdistro
, if not, manually create a PR https://github.com/ros/rosdistro/pull/32546/filesrosdistro
team to review package and merge PR (1-2 days, 1 month to get apt installable)humble
package 3
: ament_vitis - ⚠️ ⚠️ depends on ament_accelerationpackage.xml
@vmayoralbloom
releasebloom
should PRrosdistro
, if not, manually create a PRrosdistro
team to review package and merge PR (1-2 days, 1 month to get apt installable)humble
package 4
: vitis_commonpackage.xml
@vmayoralbloom
releasebloom
should PRrosdistro
, if not, manually create a PRrosdistro
team to review package and merge PR (1-2 days, 1 month to get apt installable)humble
package 5
: acceleration_firmwareevaluation and discussion https://github.com/ros-acceleration/acceleration_firmware/issues/1code fixes ⚫ (assigned to: TBD), I couldn't come up with any good scenario wherein (other than for organizational matters) keeping this package will add significant value from a source code perspective so I'm biased to recommend to drop it completely, and modify other packages accordingly. The effort of doing so (modify other packages) is something manageable if considering future firmware releases. See https://github.com/ros-acceleration/acceleration_firmware/issues/1#issuecomment-1070687656.releasepackage 6
: tracetools_accelerationpackage.xml
@vmayoralbloom
releasebloom
should PRrosdistro
, if not, manually create a PRrosdistro
team to review package and merge PR (1-2 days, 1 month to get apt installable)humble
package 7
: ros2accelerationpackage.xml
@vmayoralbloom
releasebloom
should PRrosdistro
, if not, manually create a PRrosdistro
team to review package and merge PR (1-2 days, 1 month to get apt installable)humble
Additional feedback
ROS packages release process
Additional tickets to track