search

Xilinx / PYNQ

Python Productivity for ZYNQ
http://www.pynq.io/
BSD 3-Clause "New" or "Revised" License
1.99k stars 818 forks source link

Correct environment variables #1323

Closed dspsandbox closed 2 years ago

dspsandbox commented 2 years ago

The Pynq build flow always goes through bitstream generation, microbalze BSPs, binaries... even in case a PYNQ_SDIST is specified. This is because BOARDDIR and DEFAULT_BOARDDIR variables are not part of the environment when launching /sdbuild/packages/pynq/pre.sh.

schelleg commented 2 years ago

Thank you for the contribution - give us some time to verify this as part of next image build release.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1323 (432250c) into master (59515a9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 432250c differs from pull request most recent head 206c4f9. Consider uploading reports for the commit 206c4f9 to get more accurate results Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1323    +/-   ##
========================================
  Coverage   46.47%   46.47%            
========================================
  Files          28       28            
  Lines        4953     4953            
  Branches      827      971   +144     
========================================
  Hits         2302     2302            
  Misses       2594     2594            
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59515a9...206c4f9. Read the comment docs.

schelleg commented 2 years ago

we are heavily updating sdbuild, so will close this one out just now w/o accepting ... thank you for contributing.