skalade commented 2 years ago

Base overlay builds fail for people if you don't have the y2k22 patch applied. We can add a check to see if the patch script exists in their installation, and, if it doesn't, raise a warning. This won't be necessary in future releases with newer Vivado/Vitis versions.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1356 (7fb1ddd) into master (59515a9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #1356    +/-   ##
========================================
  Coverage   46.47%   46.47%            
========================================
  Files          28       28            
  Lines        4953     4953            
  Branches      827      971   +144     
========================================
  Hits         2302     2302            
  Misses       2594     2594            
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59515a9...7fb1ddd. Read the comment docs.

schelleg commented 2 years ago

agreed with author to not take this one as later tools will not need this patch and it would be deprecated in next release.

Xilinx / PYNQ

check to see if y2k22 patch exists #1356

Codecov Report