Open dspsandbox opened 1 year ago
hi @dspsandbox - thank you for this nice contribution...
could you remove the .so file? We rebuild that as part of the sdbuild process.
we are about to release v3.0 and would like to accept this right after in a image_v3.1 branch ... at that point, we'll be able to evaluate and commit on top if we see any issue with a 2022.1 build
Merging #1384 (6204053) into image_v2.8 (59515a9) will decrease coverage by
1.11%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## image_v2.8 #1384 +/- ##
==============================================
- Coverage 46.47% 45.35% -1.12%
==============================================
Files 28 29 +1
Lines 4953 5137 +184
Branches 971 1036 +65
==============================================
+ Hits 2302 2330 +28
- Misses 2594 2748 +154
- Partials 57 59 +2
Impacted Files | Coverage Δ | |
---|---|---|
pynq/utils.py | 23.57% <0.00%> (-0.55%) |
:arrow_down: |
pynq/pl_server/hwh_parser.py | 17.24% <0.00%> (-0.41%) |
:arrow_down: |
pynq/overlay.py | 33.48% <0.00%> (-0.16%) |
:arrow_down: |
pynq/ps.py | 100.00% <0.00%> (ø) |
|
pynq/lib/__init__.py | 100.00% <0.00%> (ø) |
|
pynq/_3rdparty/xclbin.py | 100.00% <0.00%> (ø) |
|
pynq/pl_server/xclbin_parser.py | 0.00% <0.00%> (ø) |
|
pynq/pl_server/embedded_device.py | 0.00% <0.00%> (ø) |
|
pynq/lib/debugbridge.py | 10.86% <0.00%> (ø) |
|
pynq/pl_server/xrt_device.py | 29.48% <0.00%> (+0.30%) |
:arrow_up: |
... and 1 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Happy to hear that @schelleg, I have just update the PR. Best regards, Pau