Xilinx / ROCm-air-platforms

A POC platform and example for an experimental ROCm runtime release for the AMD AI Engine
MIT License
9 stars 0 forks source link

Unclear code #4

Closed keryell closed 11 months ago

keryell commented 11 months ago

The code https://github.com/Xilinx/ROCm-air-platforms/blob/main/examples/sparta-weather-stencil/weather_stencil.cpp#L130 is buggy but it is unclear to me what was the intent, since both the code and the comment might have been copy-pasted independently from elsewhere. Perhaps with

if (elf_stat.st_size > BINARY_REGION_SIZE) {

to start with?

eddierichter-amd commented 11 months ago

Good catch. I will take this.