search

Xilinx / RapidWright

Build Customized FPGA Implementations for Vivado
http://www.rapidwright.io
Other
274 stars 105 forks source link

[DesignTools.deletePblock()]: utility to delete a pblock #1020

Open Licheng-Guo opened 3 days ago

Licheng-Guo commented 3 days ago

Utility to delete a pblock.

Only tested on Vivado-generated pblocks, i.e., those existing in an out-of-box Vivado DCP

Licheng-Guo commented 16 hours ago

Can you give a motivating use-case for when this method is useful?

The current design merger does not handle XDCs, thus the final output has obsolete constraints. One simple hack for now is to delete the ones no longer needed.

I think I'd like to see a testcase as part of this PR so it's no longer "untested".

I can put a test DCP into RapidWrightDCP repo and add a test here

@clavin-xlnx Since DesignTools is already so big, and since there could be more manipulation of the XDCs, perhaps we should create a new ConstraintTools class?

I think this is a good idea, we might need more XDC manipulation when stitching complex designs. I can move the utility over there

clavin-xlnx commented 15 hours ago

@clavin-xlnx Since DesignTools is already so big, and since there could be more manipulation of the XDCs, perhaps we should create a new ConstraintTools class?

Sure, I think a ConstraintsTools class would be good, make sense to me.