search

Xilinx / Vitis-AI

Vitis AI is Xilinx’s development stack for AI inference on Xilinx hardware platforms, including both edge devices and Alveo cards.
https://www.xilinx.com/ai
Apache License 2.0
1.48k stars 627 forks source link

irps5410 error #1363

Open FBlueN opened 1 year ago

FBlueN commented 1 year ago

I have built and ran the tutorial with no modification successfully but when using Petalinux to configure the Common Software the dpu_sw_optimize.sh fails with:

Auto resize ext4 partition ...[✔] Start QoS config ...[✔] Config PMIC irps5401 .../dev/i2c-4: Device or resource busy Couldn't attach to device 0x43

I included the i2ctool in my Petalinux build but this still errors out. I am using the same base platform as the tutorial. I have see the problem, but I don't see the solution.

Vivado verision : 2022.2 Broad : zcu104 vitis-ai : 3.0

quentonh commented 1 year ago

@FBlueN I am of the understanding that dpu_sw_optimize.sh was developed prior to the inclusion of an IRPS5401 driver in the Linux upstream. The dpu_sw_optimize implementation leverages IOCTL access to the I2C device. IOCTL cannot read and write to this hardware device if the IRPS5401 driver has been probed and bound to the hardware instance. The upstream 5401 driver currently does not have the hooks to read/write the necessary registers in the device, so it is not straightforward to modify dpu_sw_optimize to simply leverage the IRPS5401 driver.

A potential work-around to this is to disable CONFIG_SENSORS_IRPS5401. If CONFIG_SENSORS_IRPS5401=y the hwmon/pmbus/ir5401.c is probed and the user space dpu_sw_optimize application will fail.

BTW, the sole purpose of this application is to modify the maximum output power available from the regulator subsystem on the ZCU104. Without these modifications, the maximum power available to the ZU+ device is insufficient to run some (many) models with multiple threads. Given that our use of dpu_sw_optimize is purely for ZCU104 max power adjustment, we have not ourselves invested in modifying the upstream driver to support the required register accesses.

FBlueN commented 1 year ago

@FBlueN I am of the understanding that dpu_sw_optimize.sh was developed prior to the inclusion of an IRPS5401 driver in the Linux upstream. The dpu_sw_optimize implementation leverages IOCTL access to the I2C device. IOCTL cannot read and write to this hardware device if the IRPS5401 driver has been probed and bound to the hardware instance. The upstream 5401 driver currently does not have the hooks to read/write the necessary registers in the device, so it is not straightforward to modify dpu_sw_optimize to simply leverage the IRPS5401 driver.

A potential work-around to this is to disable CONFIG_SENSORS_IRPS5401. If CONFIG_SENSORS_IRPS5401=y the hwmon/pmbus/ir5401.c is probed and the user space dpu_sw_optimize application will fail.

BTW, the sole purpose of this application is to modify the maximum output power available from the regulator subsystem on the ZCU104. Without these modifications, the maximum power available to the ZU+ device is insufficient to run some (many) models with multiple threads. Given that our use of dpu_sw_optimize is purely for ZCU104 max power adjustment, we have not ourselves invested in modifying the upstream driver to support the required register accesses.

Hey, I have solved this problem. Thank you.

quentonh commented 1 year ago

Thanks @FBlueN we are pleased to hear this. We will close out this issue but please reopen if needed.