search

Xilinx / bootgen

bootgen source code
Other
34 stars 42 forks source link

verifyimage: Fix segmentation fault that occurs during verifyimage. #36

Open SparkingSpork opened 3 months ago

SparkingSpork commented 3 months ago

In commit d02322b, the behavior of ReadBinaryFile was changed such that it no longer populated iHT. This caused VerifyAuthentication to access a null iHT value resulting a segementation fault.

This fix changes VerifyAuthentication to call ReadHeaderTableDetails instead, where the old functionality of ReadBinaryFile now lives.

jacmet commented 1 month ago

Thanks, I'm seeing this as well. Notice that it was fixed differently in the 2024.1 dump by making ReadBinaryFile() call ReadHeaderTableDetails(): https://github.com/Xilinx/bootgen/commit/3a0f879c611d67072aad3461f1c72d1a284cd5fc#diff-404aa20e03f1035b725ac1ea6e64c28477bb65c1663da67f64ffdb1a60552cee