Xilinx / dma_ip_drivers

Xilinx QDMA IP Drivers
https://xilinx.github.io/dma_ip_drivers/
578 stars 420 forks source link

Add vendor / device ID to in use with existing hardware. #159

Closed pbannister closed 3 months ago

pbannister commented 2 years ago

Nope. Kind of pointless in our case, as the FPGAs go into military radars, and will never appear on a general purpose device.

Yes. Bit of a cheat.

On Sat, Apr 2, 2022 at 4:19 AM Mark Harfouche @.***> wrote:

@.**** commented on this pull request.

In XDMA/linux-kernel/xdma/xdma_mod.c https://github.com/Xilinx/dma_ip_drivers/pull/159#discussion_r841064565:

@@ -45,6 +45,12 @@ MODULE_LICENSE("Dual BSD/GPL"); static int xpdev_cnt;

static const struct pci_device_id pci_ids[] = {

  • // Technovative Applications firmware for VPX552
  • { PCI_DEVICE(0x5441, 0x2022), }, // 0x5441 = "TA"
  • // Vadatech firmware for VPX552
  • { PCI_DEVICE(0xABCD, 0xC552), },

Out of curiosity, did you register to get this vendor id?

(I'm not part of xilinx, just an other user)

— Reply to this email directly, view it on GitHub https://github.com/Xilinx/dma_ip_drivers/pull/159#pullrequestreview-929561634, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUEJ6IDNMEZDRFPDKG5ITVDAUMVANCNFSM5SKLV3WQ . You are receiving this because you authored the thread.Message ID: @.***>

hmaarrfk commented 2 years ago

I'm not part of xilinx, but things. Like really custom mods, for "military radars" seem like hacks that you likely want to keep out of general purpose repos.

But that's just my opinion.

Finally i don't think xilinx really monitors these other than to list off yet an other customer they are ignoring.