search

Xilinx / dma_ip_drivers

Xilinx QDMA IP Drivers
https://xilinx.github.io/dma_ip_drivers/
578 stars 420 forks source link

[1] Remove usage of the deprecated "pci-dma-compat.h" API [2] string overflow fix #176

Closed goekce closed 1 year ago

goekce commented 2 years ago

The library does not compile against modern kernels (probably > 5.18). This PR fixes that.

The patches were generated automatically so additional manual edits may be required. They have been tested on hardware using latest XRT that integrates this repo as a library (GCC 12.2.0, Linux 5.19.2) .

hmaarrfk commented 2 years ago

I am not part of xilinx, but how did you automatically generate patches?

hmaarrfk commented 2 years ago

Hello,

My name is Mark Harfouche. I am not affiliated with Xilinx in any way. Over the years of using QDMA, I've been wanted better community organization.

I've created a fork of dma_ip_drivers which I intend to maintain and work with the community at large to improve.

The fork can be found https://github.com/hmaarrfk/dma_ip_drivers

For now, I am stating the main goals of the repository in https://github.com/hmaarrfk/dma_ip_drivers/issues/2

If you are interested in working together, feel free to open an issue or PR to my fork.

Best,

Mark

PS. Xilinx over the years, has shown that it does not intent to reply to this repository. I've found that they tend reply if you post on their own forum.

goekce commented 2 years ago

Dear Mark, also my impression is that Xilinx uses this repo only to share their source and integrate patches from their own employees (based on industrial customers having support contracts). Probably Xilinx does not prioritize the patches coming from the community.

I am very happy that you collect the community patches on your fork and I can happily create my future PRs in your repo. I have already seen a related commit in your repo 1, so I am unsure if I should include this patch in your repo. Moreover I am just starting to use the QDMA module, so I am not sure how much I can contribute.

hmaarrfk commented 2 years ago

I have already seen a related commit in your repo 1

Right, I think git am destroyed my timestamps, but I think I wrote that one a few months back.

Moreover I am just starting to use the QDMA module, so I am not sure how much I can contribute.

Those 20 or so patches came one at a time, over about 4 years. The build up is more important than a 1 off.

I noticed you found a few uninitialized constants and potential string overflows. I am happy to merge those in.

goekce commented 2 years ago

I am not part of xilinx, but how did you automatically generate patches?

I generated the patches using a Coccinelle script from a kernel patch mailing list. I wrote about that in my commit message [1]. Coccinelle [2] can be used as an automatic patch tool. It is useful for patching many files in a consistent way when a library gets deprecated. I am not much experienced in kernel development but my impression is that Coccinelle is used whenever a kernel API is deprecated and many calls must be modified.

[1] https://github.com/Xilinx/dma_ip_drivers/pull/176/commits/d3fac0c165f11f166565614989d6830bc7f2ea44

[2] http://coccinelle.lip6.fr/

goekce commented 2 years ago

I noticed you found a few uninitialized constants and potential string overflows. I am happy to merge those in.

Thanks, I will also look into your repo.