search

Xilinx / dma_ip_drivers

Xilinx QDMA IP Drivers
https://xilinx.github.io/dma_ip_drivers/
562 stars 415 forks source link

Modifications conform ChangeLog-2024.0.0 #254

Closed MischaBaars closed 7 months ago

MischaBaars commented 8 months ago 
Identifier Description
2024011900 Modifications related to kernel 6.3.0
2024011901 Modifications related to kernel 6.4.0
2024011902 Modifications related to unknown
MischaBaars commented 8 months ago

The tabsize was set to 10 on my side and might need another five minutes of work.

ekathmann-tf commented 8 months ago

I had simular build issue on Ubuntu 22.04.1 and also created a local fix. Knowing what to do I see that this pull request actually has the complete solution and even in a nicer way then that I had figured out.

MischaBaars commented 7 months ago

this pull request actually has the complete solution

If you think this has the complete solution, you're mistaken. The XVSEC part does not compile, because support for the mm_segment_t struct has been deprecated as of kernel 5.17.15. The QDMA part does compile, but has not been tested yet. The XDMA part does compile, but the xdma_mm.sh script fails to complete because it is testing BRAM upto 8k and beyond, while the IP Example Design has only 4k BRAM.

Perhaps I should learn how to sign my commits and try again.

ekathmann-tf commented 7 months ago

Thanks for the update.

Atleast it has a good solution to solve xdma driver build which does not build from the main branch... Due to that I spend 2 days to figure out how to get that to build for ubuntu 22.04 release. That is not your problem but to bad that parts of the solution have not been integrated in the main branch. I also suspect that it also helps the qdma driver but I do not build that since we don't use it.

MischaBaars commented 7 months ago

Well, I managed to get the merge request signed, but now I get this message:

Merging is blocked The base branch restricts merging to authorized users. Learn more about protected branches.

So I don't really know how to help you people any further. Building on top of this unmerged code to fix the scripts only makes things complicated. People that did have merge requests accepted seem to have left a long time ago. I have notified AMD about this and I hope the problem will be resolved soon.

Glad to help!

ekathmann-tf commented 7 months ago

Thanks for your effort!

I manually changed the code so I can continue. Just wanted to avoid other people running into the same issue. Resolving the merge rights can be a pain...

Regards, Eric

MischaBaars commented 7 months ago

Look, my primary concern is to get the Xilinx/AMD IP Design Examples working and not to get the copyright on a few lines of code pushed through.

The code is supposed to be of help. The copyright is left untouched.