search

Xilinx / embeddedsw

Xilinx Embedded Software (embeddedsw) Development
Other
963 stars 1.07k forks source link

add function prototype for msleep() in sleep.h #324

Closed digitalnumeric closed 2 days ago

digitalnumeric commented 1 week ago

msleep() is listed as supported by XilTimer, but its prototype is missing from sleep.h. Standalone Library Documentation: BSP and Libraries Document Collection (UG643)

XilTimer.c has a msleep() function: xiltimer.c on Github void msleep(unsigned long mseconds) { XilTimer_Sleep(mseconds, XTIMER_DELAY_MSEC); }

msleep()'s prototype is missing from both XilTimer's sleep.h and common's sleep.h: XilTimer's sleep.h on Github common's sleep.h on Github

This can be corrected by adding the msleep() prototype to both the above files as done in the attached patch file: msleep.patch

Reference to where this was reported on the forums earlier this year: Vitis Unified msleep() function missing from sleep.h but present in xiltimer.c

Reference to the original issue on github which was closed and replaced by this new issue with a patch file: msleep has no function prototype #305

anirudha1977 commented 6 days ago

Thanks for reporting this. Sorry for this from our end. We will fix this in the next release. We have created an internal tracking item for this.

digitalnumeric commented 5 days ago

Sound good. Thank you.

digitalnumeric commented 2 days ago

Based on a reply to https://github.com/Xilinx/embeddedsw/issues/305 and a 2nd look at Vitis 2024.2 it appears it is there in all the files where it is intended to be.