Xilinx / finn

Dataflow compiler for QNN inference on FPGAs
https://xilinx.github.io/finn
BSD 3-Clause "New" or "Revised" License
681 stars 218 forks source link

Fix fast data packing for rtlsim #1080

Closed fpjentzsch closed 4 weeks ago

fpjentzsch commented 1 month ago

Introduces masking and an additional check to ensure fast packing mode always behaves like the hex string packing and does not sign-extend.

See https://github.com/Xilinx/finn/pull/983 for why this was problematic.

Includes a new unit test.