Xilinx / finn

Dataflow compiler for QNN inference on FPGAs
https://xilinx.github.io/finn
BSD 3-Clause "New" or "Revised" License
681 stars 218 forks source link

WIP: Non-Interactive Docker Run #967

Open iksnagreb opened 5 months ago

iksnagreb commented 5 months ago

When running some automated finn builds by some experiment manager doing parameter sweeps, the jobs failed with some TTY issues from within docker, which I have tracked down to the container being connected to a non-TTY output device. So I think there should be an option to disable DOCKER_INTERACTIVE, when it is not absolutely needed. This PR is certainly not ready (it just disables DOCKER_INTERACTIVE...). This is more of reminder, to myself that I rely on this being fixed...

This needs to be properly refactored and probably be exposed to the outside so the user is in control. Maybe default to interactive runs while introducing some flag to turn this off?