search

Xilinx / inference-server

https://xilinx.github.io/inference-server/
Apache License 2.0
43 stars 13 forks source link

Replace Jaeger exporter with OTLP #187

Closed varunsh-xilinx closed 1 year ago

varunsh-xilinx commented 1 year ago

Summary of Changes

Closes #185

Motivation

The Jaeger exporter is being deprecated in July 2023.

Implementation

Changing exporters turned out to be a fairly drop-in replacement. Versions for both of the dependencies needed to be bumped up but there were no API changes.

The tracing documentation for Jaeger also needed updating.

Notes

Rebuild the container to get these changes.

There's also an error message printed when the OTLP exporter can't connect to a collector. This is expected if you're not running something. While the message could be suppressed by disabling logging in opentelemetry, I think it's useful to have around. It can also be removed by excluding tracing from the server compilation.

gbuildx commented 1 year ago

Build failed!

gbuildx commented 1 year ago

Build failed!

gbuildx commented 1 year ago

Build successful!

gbuildx commented 1 year ago

Build successful!