Xilinx / inference-server

https://xilinx.github.io/inference-server/

Apache License 2.0

43 stars 13 forks source link

Add multi input/output channels support to migraphx worker; new example scripts for Yolo and Bert models" #83

Closed bpickrel closed 2 years ago

bpickrel commented 2 years ago

Summary of Changes

Added support for multiple input or output channels, needed by many current machine learning models.
Added example scripts for Yolo object detection (1 input; 3 outputs) and Bert language processing (4 inputs; 3 outputs) which could not be run before this.
Modified existing hello-migraphx example to submit multiple requests asynchronously, to comply with the engine's recent change in batching interface.

gbuildx commented 2 years ago

Can one of the admins verify this patch?

bpickrel commented 2 years ago

What is the source for the crowd.jpg image?

https://farm3.staticflickr.com/2009/2306189268_88cc86b30f_z.jpg and the MIGraphX repo

varunsh-xilinx commented 2 years ago

Why have you changed all of them to MIT now? If there's a new file you're adding that you've largely copied from somewhere else and it comes with an existing license header, then you should keep that header but for your own work, continue with Apache 2. Your existing examples shouldn't be relicensed

varunsh-xilinx commented 2 years ago

What is the source for the crowd.jpg image?

https://farm3.staticflickr.com/2009/2306189268_88cc86b30f_z.jpg and the MIGraphX repo

Thanks. The image is from https://www.flickr.com/photos/mattmangum/2306189268/ under a CC BY 2.0 license. Is there a reason you're adding this file for the yolo example rather than using the existing bicycle picture? That image gives you nicer boxes with higher confidences anyway

bpickrel commented 2 years ago

I got the link to the picture from the AMDMIGraphX repository. I'm using it because it's the same image as the script I modeled mine on, and I can compare results. If I add the image to the "proteus get" downloads to avoid the attribution problems of putting it in the repo, does it matter what directory it goes in?

bpickrel commented 2 years ago

This is per instructions from MVermeulen and guidance from company legal. The scripts they're based on come from our team, and we've had an initiative in recent months to correct the license statements on all our files. The MIT licenses are the ones from the source scripts.

varunsh-xilinx commented 2 years ago

Is this okay to merge or are you still adding more commits?

bpickrel commented 2 years ago

I'm finally done.

bpickrel commented 2 years ago

Closed by mistake; clicked the wrong button. Reopened!