search

Xilinx / llvm-aie

Fork of LLVM to support AMD AIEngine processors
Other
107 stars 12 forks source link

[AIE2] Enable up-combining for VLD + UNPACK #241

Open andcarminati opened 5 days ago

andcarminati commented 5 days ago

If we can't delay VLD, we can try to antecipate UNPACK. This approach can be extended to other selection combiners.

andcarminati commented 5 days ago

QoR:

|--------------------------------------------------------------|------------|----------|--------------|
| Core_Compute_Cycle_Count                                     | aie-public | This PR. | Total diff   |
|--------------------------------------------------------------|------------|----------|--------------|
| Softmax_bf16_0                                               |       6350 |     6351 | SAME(+0.02%) |
|--------------------------------------------------------------|------------|----------|--------------|
| ThresholdedRelu_aie2_int8                                    |        865 |      849 | IMPR(-1.85%) |
|--------------------------------------------------------------|------------|----------|--------------|
| Erf_aie2_int8_0                                              |       2554 |     2490 | IMPR(-2.51%) |
|--------------------------------------------------------------|------------|----------|--------------|
| Erf_aie2_int8_0_ptr_interface                                |       2533 |     2469 | IMPR(-2.53%) |
|--------------------------------------------------------------|------------|----------|--------------|
| HardswishAsHardsigmoid_aie2_0                                |       1368 |     1240 | IMPR(-9.36%) |
|--------------------------------------------------------------|------------|----------|--------------|
| Hardswish_aie2_0                                             |       1368 |     1240 | IMPR(-9.36%) |
|--------------------------------------------------------------|------------|----------|--------------|
| Averege diff                                                 |            | -0.07%   | -0.07%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Diff stdev                                                   |            |     0.75 |         0.75 |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #1                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #2                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #3                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #4                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #5                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #6                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #7                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #8                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
| Quantile #9                                                  |            | +0.00%   | +0.00%       |
|--------------------------------------------------------------|------------|----------|--------------|
andcarminati commented 3 days ago

Hi @gbossu, all comments were addressed. Thank you for the review ;-).