Xilinx / mlir-aie

An MLIR-based toolchain for AMD AI Engine-enabled devices.
Other
260 stars 76 forks source link

Matrix Multiplication Improvements #1551

Closed andrej closed 2 weeks ago

andrej commented 3 weeks ago

cc @jgmelber

andrej commented 3 weeks ago
andrej commented 3 weeks ago

@jgmelber Kindly kick off the tests for this when you get a chance. I fixed a number of issues with the matmuls that slid by because the verification tolerance was a bit high. I reduced the tolerance, so let's see if the tests reveal more issues.

andrej commented 3 weeks ago

@jgmelber Could you please kick off the CI again? TIA

jgmelber commented 3 weeks ago

@andrej matrix_vector still needs to be fixed, the rest look okay

andrej commented 3 weeks ago

@jgmelber Hopefully this will pass now

andrej commented 2 weeks ago

@jgmelber Could you kick off the tests on this please?

andrej commented 2 weeks ago

Looks like tests pass but I forgot to format. Another try please @jgmelber ?